Forum OpenACS Improvement Proposals (TIPs): Tip #16 (Approved): Include new package: Redirect

1: Tip #16 (Approved): Include new package: Redirect

Posted by Tilmann Singer on 09/10/03 04:35 PM

I would like to include the redirect package in the toolkit. From its documentation:

This is a simple package that sends a redirect to another location, depending on its parameter settings. It is intended for the situation when you moved parts of your site to another location in order to reorganise your site, but don't want old links such as users bookmarks, links from remote sites, external search engine hits etc. to break.
Usage
Mount it at the old location using the openacs site-map, and set its NewURL parameter to the new location. E.g. when you moved a tree of your site from '/some/old/path/' to '/newurl/' then mount an instance of redirect at '/some/old/path/', and set its NewURL parameter to '/newurl/'.

More at http://openacs.org/forums/message-view?message_id=118065.

The package is in file-storage: http://openacs.org/storage/file?file_id=118294

I would also suggest to set the core flag to true so that it gets installed upon OpenACS installation, since it serves a general purpose that might as well be implemented in the site-map/request-processor if it wouldn't be easier like that as a package, and it is fairly lightweight (no datamodel, few files).

2: Re: Tip #16 (Proposed): Include new package: Redirect (response to 1)

Posted by Simon Carstensen on 09/10/03 06:01 PM

Very cool. Has this been committed yet? I couldn't find it anywhere in CVS.

I was wondering how hard it would be to implement a "Move instance" feature in Site Map that does exactly what you describe above - moves the package to another URL and then mounts the redirect package at the old one.

3: Re: Tip #16 (Proposed): Include new package: Redirect (response to 1)

Posted by Jade Rubick on 09/10/03 08:12 PM

I really like this idea.

4: Re: Tip #16 (Proposed): Include new package: Redirect (response to 1)

Posted by Andrew Piskorski on 09/13/03 09:01 PM

It doesn't sound like a very capable redirect package, but it is very small and simple (just one short index.vuh file), so sure, why not include it in the toolkit? Fancier redirect functionality could always be added into this package at a later date if desired.

5: Re: Tip #16: Approved by Lars Pind (response to 1)

Posted by Lars Pind on 09/22/03 08:14 PM

I'm not convinced it should be part of initial-install (core), but I do think we should put it in CVS.

6: Re: Tip #16: Approved by Lars Pind (response to 5)

Posted by Tilmann Singer on 09/24/03 08:05 PM

Please, can someone else from OCT approve this TIP so that I can commit it before the freeze? I'll change it to not be part of a default install as Lars suggested.

7: Re: Tip #16 (Proposed): Approved by rbm (response to 1)

Posted by Roberto Mello on 09/24/03 09:16 PM

Good work Til. This will be useful to many.

-Roberto

8: Re: Tip #16 (Proposed): Include new package: Redirect (response to 1)

Posted by Roberto Mello on 09/24/03 10:07 PM

Hmmm, I just thought of this...

How dos Redirect compare with the Gatekeeper package? Shouldn't those be integrated or merged? If not, then should redirect superced gatekeeper (to avoid yet another redundant, non-maintained package)?

Gatekeeper seems to do more than redirect, like forward cookies.

If Redirect is going to superceed Gatekeeper, we need some upgrade path, no?

-Roberto

9: Re: Tip #16 (Proposed): Include new package: Redirect (response to 8)

Posted by Tilmann Singer on 09/24/03 10:33 PM

Gatekeeper does something different in my opinion - it passes the request through, and adds openacs security handling. I don't see a problem having different packages for that - actually it is less confusing this way.

Nevertheless gatekeeper could use some documentation.

10: Re: Tip #16 (Proposed): Include new package: Redirect (response to 1)

Posted by Don Baccus on 09/25/03 02:06 AM

How hard would it be to add your index.vuh file to gatekeeper with some documentation and a flag which tells the mounted instance whether or not to do a simple redirect or to do the more complex security stuff gateway does?

Though I like "redirect" as a name better - I know what that does, I just don't know how much that does from the name, while "gatekeeper" doesn't tell me much.

I approve of it being added regardless, just asking a question, though I'm with Lars, let's not install by default.

11: Re: Tip #16 (Proposed): Include new package: Redirect (response to 1)

Posted by Peter Marklund on 09/25/03 09:52 AM

Approved

12: Re: Tip #16 (Proposed): Include new package: Redirect (response to 11)

Posted by Tilmann Singer on 09/29/03 03:29 PM

Added redirect package to cvs, with the option to be installed by default set to false.

I did not consider adding the functionality to the gatekeeper package, due to the misleading name. Should we merge gatekeeper into redirect? Rename gatekeeper to http-pass-through? Leave it and pursue more important issues?