Forum OpenACS Improvement Proposals (TIPs): TIP #117 (IMPLEMENTED): Remove md5-procs from acs-tcl

Collapse
1: TIP #117 (IMPLEMENTED): Remove md5-procs from acs-tcl
Posted by Emmanuelle Raffenne on 11/19/07 07:32 PM
md5-procs.tcl appears to be a copy of a previous version of the md5 implementation in tcllib. Now that we requires tcllib, it is provided and there's no need to keep it in acs-tcl.
Collapse
2: Approve: Re: TIP #117: Remove md5-procs from acs-tcl (response to 1)
Posted by Dave Bauer on 11/19/07 08:00 PM
Approve
Collapse
3: Re: APPROVE: TIP #117: Remove md5-procs from acs-tcl (response to 1)
Posted by Don Baccus on 11/19/07 08:28 PM
approved
Collapse
4: Re: TIP #117: Remove md5-procs from acs-tcl (response to 1)
Posted by Victor Guerra on 11/19/07 10:12 PM
Approve
Collapse
5: Re: TIP #117: Remove md5-procs from acs-tcl (response to 1)
Posted by Gustaf Neumann on 11/20/07 09:45 AM
approved
Collapse
6: Re: TIP #117: Remove md5-procs from acs-tcl (response to 1)
Posted by Malte Sussdorff on 11/21/07 09:29 AM
approved. Is there any work involved to make the "switch" ?
Collapse
7: Re: TIP #117: Remove md5-procs from acs-tcl (response to 6)
Posted by Emmanuelle Raffenne on 11/21/07 01:10 PM
Malte,

No, there's no work involved. I'm not sure md5 is even used, I've grep'd core+dotlrn and didn't find any use of it.

Collapse
8: Re: TIP #117: Remove md5-procs from acs-tcl (response to 7)
Posted by Rocael Hernández Rizzardini on 11/21/07 02:47 PM
I don't think it is used at all, probably some legacy code we got from acs.

Approved.

Collapse
9: Re: TIP #117: Remove md5-procs from acs-tcl (response to 7)
Posted by Mark Aufflick on 11/21/07 04:19 PM
It was used in 4.x email/mime handling. md5.tcl. base64.tcl and mime.tcl used to be nastily sourced in because of aolserver 3's poor package handling.

Eg:

http://cvs.openacs.org/cvs/openacs-4/packages/acs-tcl/tcl/html-email-procs.tcl?rev=1.2&view=auto

It's not been used for some time I believe.

Collapse
10: Re: TIP #117: Remove md5-procs from acs-tcl (response to 1)
Posted by Emmanuelle Raffenne on 11/28/07 02:08 PM
Done and committed to HEAD.