I just spent 1-2 hours debugging a problem caused by db_multirow clobbering variables in its callers scope with the values in the last selected row. We have too much uncontrolled variable clobbering and too little variable namespace separation in general in OpenACS. The arguments in favor of this change have been exhaustively presented in this thread:
http://openacs.org/forums/message-view?message_id=103734
I believe any upgradability difficulties caused by this change (which I estimate to be small) in the long run will be outweighed by the improved robustness of the toolkit.
Request notifications