Forum OpenACS Improvement Proposals (TIPs): Re: TIP #38 (Proposed): Modify template path resolution for ad_return_template, master tag and include tag

Collapse
2: Re: TIP #38 (Proposed): Modify template path resolution for ad_return_template, master tag and include tag (response to 1)
Posted by Jeff Davis on 12/11/03 02:39 PM
I don't like the faux uri form for explicit paths (well, mostly I object to the package key being in the "scheme" spot, it also makes writing things that walk all the adp's and pull out urls do stupid things). I would find package://<key>/path a lot less objectionable. Another alternative would be "<package_key>:path" or something like that.

Any notion of what existing things would break?

Can you give concrete examples of where the current behavior is a problem?

Collapse
3: Re: TIP #38 (Proposed): Modify template path resolution for ad_return_template, master tag and include tag (response to 2)
Posted by Lee Denison on 12/11/03 04:11 PM
I started with the idea of "<package-key>:path" and my current implementation will accept that as well.  package://<key>/path is definately more correct as a uri - I was just looking for something less verbose than /packages/<package-key>/lib/path.

I reasoned my way to the idea that things would only break if a current absolute path happened to coincide with a path in the packages lib directory but some grepping seemed to indicate that this was unlikely.  I've been running my modification for a week or so an haven't found anything broken so far.

The current behaviour is not a problem other than if we want to encourage folks to put stuff in lib it should be as easy as possible to use them.  Not needing to put /packages/<current-package>/lib seems like a good start.