Forum .LRN Q&A: Forums plain text formatting bug?

Posted by Dave Bauer on 07/23/02 08:29 PM

It looks like forums is not honoring CR for a line ending in postings.
If you type to CRs to insert a blank line, the preview and post view
page just show one big block of text.

I noticed this on a bboard migration test. All the paragraph
formatting was lost.

I don't know if it is a display issue, or a database issue.

2: Response to Forums plain text formatting bug? (response to 1)

Posted by Dave Bauer on 07/23/02 08:31 PM

Sorry. This is on the Postgresql version of forums. Although at the sloan dotlrn demo site it looks like the same thing is happening.

3: Response to Forums plain text formatting bug? (response to 1)

Posted by Arjun Sanyal on 07/24/02 06:43 AM

Yup, this is on oracle too. We'er working on a fix.

4: Response to Forums plain text formatting bug? (response to 1)

Posted by Deds Castillo on 07/24/02 01:20 PM

Could it be a browser issue? I'm only experiencing this on
Konqueror. Galleon and Netscape are able to display it fine.

5: Response to Forums plain text formatting bug? (response to 1)

Posted by Lars Pind on 07/26/02 08:59 AM

I just noticed this commit in the CVS tree, and figured it was in response to this thread:

Modified Files:
	text-html-procs.tcl 
Log Message:
added code to ad_text_to_html to Convert _single_ CRLF's to <br>'s to preserve line breaks

What I said in reponse was:

It was very much on purpose that I didn't include this in code originally.
If you do this, then the formatting begins to be dependent on accidental returns that you cannot see in your textarea.
I decided that since the desire for explicit formatting is relatively rare, you'll have to live with having to either (a) select the preformatted style, (b) select HTML style and add the <pre ></pre> tags yourself, or (c) stick with plain, but use double-enters for your line breaks.

/Lars

6: Response to Forums plain text formatting bug? (response to 1)

Posted by Tracy Adams on 07/27/02 06:53 AM

I'm looking a the current code and am wondering if this is fixed.

I see a call to ad_text_to_html in /forums/www/message-preview-chunk.tcl. However, I don't see an attempt to convert text to html in /forums/www/message-view.tcl. I also checked the possibility that the content is converted before it put in the database and this was not the case.

So my conclusion is that there is no text-to-html conversion attempted at all. Is this the case and is someone actively working on it (in which case I'll just wait)?

7: Response to Forums plain text formatting bug? (response to 1)

Posted by Arjun Sanyal on 07/27/02 08:31 PM

> I'm looking a the current code and am wondering if this is fixed.

Nope, this is not fixed yet. We're working with Lars on it.

I've been working on forums and have a bunch of uncommitted UI improvements. I'll commit once we figure out this issue.