# 2. handle special case: if the root is a prefix of the URL,
# remove this prefix from the URL, and redirect.
if { $root ne "" } {
if { [regexp "^${root}(.*)$" $url match url] } {

if { [regexp {^GET [^\?]*\?(.*) HTTP} [ns_conn request] match vars]\
} {
append url ?$vars
}
if { [security::secure_conn_p] } {
# it's a secure connection.
...
} else {
ad_returnredirect \
-allow_complete_url http://[ad_host][ad_port]$url
return "filter_return"
}
}


Is rp_form_put the correct proc to use to pass along POST variables in this case?

Why are you doing a redirect in this case?

Is someone going to http://domain.com/subsite when you want them to go to http://subsite.com ?

It calls ad_conn url which returns /subsite/page even if we are operating from a mapped subsite. So the RP redirects to /page losing the POST vars when we come from a form.

Can you explain the case you are trying to fix?

Why is the "root a prefix of the URL?" I am not sure what that means in this context.

Ie: What URL is being requested and what URL is it redirect to? Why is a redirect happening on a POST?

"A confirmation template in acs-templating (path above) generates a return_url from [ad_conn url] of /subsite1/page."

I haven't had time to dwell in the issue here, but having worked a bunch with host node mapping and ad_conn url issues, this may be of value:

site_node::conn_url

Use this in place of ns_conn url when referencing host_nodes. This proc returns the appropriate ns_conn url value, depending on if host_node_map is used for current connection, or hostname's domain.

Defined in CVS HEAD packages/acs-tcl/tcl/site-nodes-procs.tcl

It helps set up a sane return_url etc. with form processing.

cheers,

Torben

I've posted this same bug here on the forums and in the bugtracker a long time ago, and got no feedback. Take a look: http://openacs.org/forums/message-view?message_id=1630910

For now, I changed the confirm_template to use ns_conn instead of ad_conn, wich just owrks. But it seems a terrible workaround for me.

I did a long investigation about the implications on RP, and I could not get to any conclusion. I tried the same pproach that you said on host node map patch, and many others. But got too many problems, such as the ones Gustaf's pointed.

We should make a joint effort to fix this problem now, because it's a nice feature on OpenACS that just doesn't work.

Trying to redirect a POST is just fixing the symptom and not the real bug.

The POST should always go to the same domain name that the form was generated from so there is no need for a redirect.

This would be the simplest solution, but doesn't work for all cases, because sometimes ad_conn url is used to build a reference only available from the main domain.

The alternative is to swapp ad_conn url with site_node::conn_url for the specific cases that do work.

It's been a couple of years since I've been messing with host node mapping.

Apparently site_node::conn_url isn't a direct substitute as I mentioned. I'm terribly sorry about spouting that without re-checking.

site_node::conn_url is a proc for building urls that work when ad_conn url breaks for host node mapping.

One can use site_node::conn_url to generate urls that work with or without hostnode mapping, so that a host node mapped site works from the main domain as well.

Using site_node::conn_url is really useful when the main domain has a ssl/https setup, because the site can switch back and forth between http/https without generating a security warning or changing the display templates. You can direct a user to login via https and then switch them back to http on the hostnode mapped subsite after login. The UI flow is smooth.

The action URL for the form should be to the host node mapped URL so there should not be any problem.

Please provide a code sample where the form action goes to the main site instead of the URL of the request.

For example, on a host-mapped site in file-storage, go to modify permissions.
The standard permissions table is visible.

form action="/mapped_subsite/permissions/perm-modify" method="post"

The RP subsite hack can't process the post so we get the error:

We had some problems with your input:

You must supply a value for object_id
You must supply a value for return_url

When I try the same thing using the main site URL it works as expected.

Dave can you try to reproduce this?

Pinning down where to set ad_conn url is tricky, so if you get a chance, any help would be appreciated.

I've done a lot of investigation on this problem, and yes, basically any call the ad_con will eventually fail in a host node mapped subsite.

The fix is tricky befure the call to ad_conn -set is done AFTER the filters are proccessed. So, even if we fix the filters (rp_filter) and fix the redirect, ad_conn -set won't see this change.

To fix it would be a big problem, because we would have to change the exact place in request-processor where the ad_conn -set is called. Ni first looking it would be a major rewriting of request processor code.

Mayvbe somebody with better knowledge on RP can propose a better solution.

Ryan, Eduardo,

I agree, openacs-core things break in host-node mapped sites. Many times, it's because a package is limited to a single mount, often outside of the host node mapped file hierarchy. These should be re-worked to handle more general cases.

I guess what I'm saying is that the rp_handler is not the place to be throwing form posts. Use it to generate urls that work in the first place.

Most apps reside within a single directory. By omitting all forward slashes, browsers use existing directories. The case is simple for all these host node map directories.. no change required. For example, take a look at birdswelcome.com All the forms in that site use post. All are in a single directory. No issues, even when accessing via dekkasupply.com/birdswelcome

For apps that require processing between a hostnode-mapped domain and the main-domain, such as login and register, build the post and return_url ahead of time using absolute references.

site_node::conn_url is helpful. It is especially useful in a place like index.vuh in a hostnode-mapped directory.

Here's an example from universallogos.com/index.vuh

set conn_url [site_node::conn_url]
set conn_url0 [ad_conn url]
ns_log Notice "/www/universallogos/index.vuh conn_url = '${conn_url}', ad_conn url = ${conn_url0}"
if { $conn_url eq "" } {
    regsub -- {/universallogos/} $conn_url0 {/} conn_url
}

if { [string match "/resources/*" $conn_url ] } {
    set redirect_url "/www${conn_url}"
    rp_internal_redirect $redirect_url
    ad_script_abort
} elseif { [string match "/search/*" $conn_url ] } {
    set query [ns_conn query]
    set redirect_url "http://dekkasupply.com${conn_url}?${query}"
  ns_log Notice "/usr/local/www/dekkasupply.com.com/openacs-4/www/universallogos/index.vuh: redirecting to: ${redirect_url}"
    ad_returnredirect -allow_complete_url $redirect_url
    ad_script_abort

} else {

    ::xowiki::Package initialize -ad_doc { 
 
        The script uses an XoWiki page as root page 
        of the site. Here, the start page is /xowiki/ followed 
        by the actual URL, as specified as the value after "-url" below. 
        Replace this value, in case a different XoWiki instance 
        name should be used. 
   
        @author Gustaf Neumann (gustaf.neumann@wu-wien.ac.at) 
        @creation-date July, 2006 
        @cvs-id $Id: index.vuh,v 1.5 2006/09/15 16:45:00 gustafn Exp $  
    } -parameter { 
        {-m view} 
        {-folder_id:integer 0} 
    } -url /universallogos/xowiki${conn_url}

    ::$package_id reply_to_user [::$package_id invoke -method $m] 
    ad_script_abort 
}

cheers, Torben

Perhaps you missed the second point in that post.

It begins with: "For apps that require processing between a hostnode-mapped domain and the main-domain"..

Also, see my previous post to Eduardo regarding building return_url in ad_get_login_url.

You should be able to build a proc that returns the absolute reference you need, without messing with the request processor or redirecting.

Are you trying to hide a form processing url from the web? If so, put the form processing in an index.vuh page. No redirect required.

"The case is: you should point an URL to /subsite/page and it should just work on host node maped subsite. Try to map all the places in the system where this call appears is very difficult, and it can always lead to some fail."

Between Ryan's exampe, and yours, I do believe I'm understanding the issue now. I still think the fix is to have the code provide the correct url.

ad_conn url is an incomplete solution that breaks expected behavior on host-node mapped sites.

Given the complexity of the rp and the depth of the fix that is required, the appropriate fix, to me, seems to be to replace the instances of ad_conn url with a proc that has predicted behavior, ie returns ad_conn url for mainsite, and a modified url for the host-node mapped sites (when serving pages from there). site_node::conn_url *was* supposed to help support creating a proc like this, but it *is* broken at the moment.. I'll see if I can re-create the proc as a replacement for ad_conn url as originally intended.

cheers,

Torben

What if the page I am posting to is a lib file inside acs-subsite? I can't very well embed acs-subsite inside (as in my case) a package that extends it.

I don't see getting the proper URL as unique behaviour.
Calling ad_conn url while in http://mapped_host/
should return "/" not /subsite/

These URLs don't satisfy the redirect condition in the RP so the POST is processed.

For the permissions admin include, here is an example of a modification on oacs-5-6 branch:

Index: www/permissions/perm-include.tcl
===================================================================
RCS file: /cvsroot/openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl,v
retrieving revision 1.11
diff -u -r1.11 perm-include.tcl
--- www/permissions/perm-include.tcl 4 Jan 2008 16:34:01 -0000 1.11
+++ www/permissions/perm-include.tcl 17 Aug 2011 17:38:00 -0000
@@ -61,9 +61,7 @@
display_template {input type="checkbox" name="perm" value="@permissions.grantee_id@,remove"}
}

-
-
-set perm_url "[ad_conn subsite_url]permissions/"
+set perm_url "[subsite::get_url]permissions/"

if { ![exists_and_not_null user_add_url] } {
set user_add_url "${perm_url}perm-user-add"